Skip to content

Fix #54, update lgtm file#55

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
avan989:master
Mar 23, 2020
Merged

Fix #54, update lgtm file#55
astrogeco merged 1 commit intonasa:integration-candidatefrom
avan989:master

Conversation

@avan989
Copy link
Contributor

@avan989 avan989 commented Mar 16, 2020

Describe the contribution
Update lgtm file to include python

Testing performed

  1. Go to https://lgtm.com/projects/g/nasa/cFS/logs
  2. Go to log tab
  3. Click on "test analysis configuration"
  4. Paste new lgtm file
  5. Click "try build"
  6. Verify both C and python code was extracted and analyze

Contributor Info - All information REQUIRED for consideration of pull request
Anh Van, NASA Goddard

@avan989 avan989 changed the title update lgtm file Fix #54, update lgtm file Mar 16, 2020
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 17, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Mar 18, 2020

CCB 20200318 - Approved

@astrogeco astrogeco added CCB - 20200318 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Mar 18, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate March 23, 2020 17:03
@astrogeco astrogeco merged commit 5bbb7b7 into nasa:integration-candidate Mar 23, 2020
@astrogeco astrogeco mentioned this pull request Mar 23, 2020
Merged
@skliper skliper linked an issue Mar 23, 2020 that may be closed by this pull request
Update lgtm to include python #54
Closed
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
@jphickey
Fix nasa#55, resolve uninitialized pointer warning
0ea1212 
Initialize the variables at the beginning of the function.  They
will be set again in the loop, but this avoids the compiler warning.
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
@astrogeco
Merge pull request nasa#85 from jphickey/fix-55-uninit-ptr-warning
e8562bf 
Fix nasa#55, resolve uninitialized pointer warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skliper skliper skliper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Milestone

Bootes

Development

Successfully merging this pull request may close these issues.

Update lgtm to include python

4 participants

@avan989 @astrogeco @skliper @anhvan989