Fix #465 #463, CI document deployment fixes#466
Merged
Conversation
skliper
added
the
CCB:Ready
2 tasks
astrogeco
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Now always running for main branch actions (will deploy on fork if you push main). Also rejecting attempts to deploy and use the cache at the same time since I can't figure out how to make that work (password fails on deploy).
Testing performed
Tested w/ a push of main to my fork at https://github.com/skliper/cFE/actions/runs/2203904971, note that branch also contains updates to deploy locally to avoid the password issue.
Expected behavior changes
Deploy on push to main
System(s) tested on
CI
Additional context
Only caller impact is for cFE that tried to use the cache and reusable deploy. CF and cFS workflows not impacted.
Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC