Fix #382, Reuse CodeQL, Static Analysis, Format Check#386
Merged
Fix #382, Reuse CodeQL, Static Analysis, Format Check#386
Conversation
ArielSAdamsNASA
force-pushed
the
fix-382-reuse-workflows
branch
2 times, most recently
from
be8ade6 to
506d0a5
Compare
ArielSAdamsNASA
added
CCB:Ready
ArielSAdamsNASA
force-pushed
the
fix-382-reuse-workflows
branch
from
506d0a5 to
d47752f
Compare
Contributor
Author
|
Change Static Analysis workflow to remove inputs.module. Add matrix back. Use cppcheck code for strict modules, but change the directory using an input. Tested: |
ArielSAdamsNASA
force-pushed
the
fix-382-reuse-workflows
branch
from
d47752f to
a5c3097
Compare
This was referenced Oct 27, 2021
ArielSAdamsNASA
force-pushed
the
fix-382-reuse-workflows
branch
from
a5c3097 to
8f11535
Compare
skliper
reviewed
Oct 28, 2021
skliper
reviewed
Oct 28, 2021
| jobs: | ||
| static-analysis: | ||
| name: Static Analysis | ||
| uses: nasa/cFS/.github/workflows/static-analysis.yml@main No newline at end of file |
Contributor
There was a problem hiding this comment.
For now we probably want to add in the full directory list for the submodules to do the strict static analysis on so it replicates the old functionality. Can be just one big list now. Eventually the idea would be to abstract the list out at the cFS level and get it from each repo, but for now hard coding is fine.
ArielSAdamsNASA
force-pushed
the
fix-382-reuse-workflows
branch
from
8f11535 to
387df8d
Compare
astrogeco
added
CCB:Approved
Contributor
|
CCB:2021-11-03 APPROVED
|
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Nov 18, 2021
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
2 tasks
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Nov 18, 2021
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
astrogeco
force-pushed
the
fix-382-reuse-workflows
branch
from
f7b8cbb to
d686e62
Compare
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 6, 2021
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
astrogeco
changed the title
astrogeco
added a commit
to ArielSAdamsNASA/cFS-JSF-Rules
that referenced
this pull request
Dec 6, 2021
Co-authored-by: Ariel Adams <[email protected]>
astrogeco
force-pushed
the
fix-382-reuse-workflows
branch
from
d686e62 to
7e31d11
Compare
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 6, 2021
Fix nasa#382, Reuse CodeQL, Static Analysis, Format Check
Co-authored-by: Ariel Adams <[email protected]>
astrogeco
force-pushed
the
fix-382-reuse-workflows
branch
from
7e31d11 to
cff81c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #382
Testing performed
Tested on forked repos.
OSAL Static Analysis Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1387270204 - runs bundle and strict osal
cFS Static Analysis Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390418206
OSAL CodeQL Reuse cFE Build: https://github.com/ArielSAdamsNASA/osal/runs/4023159610?check_suite_focus=true
OSAL CodeQL Reuse OSAL Default: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702434
cFS CodeQL Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390777421
OSAL Format Check Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702433
cFS Format Check: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390865379
Expected behavior changes
cFS will hold the workflows for CodeQL, Static Analysis, and Format Check. These workflows will be called by all subrepos to use. cFS has to call on CodeQL and Static Analysis for the workflows to work. Format check does not need to be reused in cFS since there are no inputs.
To explain the new workflows, a diagram has been added to the README.md file. The PR does not show the image in the README.md file, but the same code and image works in the forked repo: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/blob/fix-382-reuse-workflows/.github/workflows/README.md
Additional context
The workflows calling the original actions will not work until it is integrated in main because of this code.
uses: nasa/cFS/.github/workflows/static-analysis.yml@mainDocumentation: https://docs.github.com/en/actions/learn-github-actions/reusing-workflows
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal