Fix #334, Add Functional Tests Step to CI#350
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Sep 22, 2021
Merged
Fix #334, Add Functional Tests Step to CI#350astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Contributor
|
Looks like 4 jobs that really could be consolidated? Build, make test, then run with the functional test app. Or if these really need to be separate could the build be archived so it doesn't actually need to be built 4 times? Currently may be burning a lot of minutes w/ the duplicated work (especially since this is matrixed). |
astrogeco
approved these changes
Sep 15, 2021
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
I'm fine with the separate jobs. We can figure out how to reuse the build files using cache. The one thing i would add is a dependency between run and functional test so that we don't even try to run the functional tests if plain run ./core-cpu doesn't work
ArielSAdamsNASA
force-pushed
the
fix-334-functional-tests-ci
branch
from
0e36279 to
22090ee
Compare
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Sep 22, 2021
…sts-ci Fix nasa#334, Add Functional Tests Step to CI
astrogeco
force-pushed
the
fix-334-functional-tests-ci
branch
2 times, most recently
from
1d60ed6 to
bf06145
Compare
- Combine build-prep and build-cfs jobs - Rename jobs and artifacts for consistency and clarity - Update workflow trigger for codeql build
astrogeco
force-pushed
the
fix-334-functional-tests-ci
branch
from
bf06145 to
fa8512c
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #334
Testing performed
Tested on fork repo.
Deprecated Build, Test, and Run: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1198344779
Build, Test, and Run [OMIT_DEPRECATED=true]: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1198344780
Also seen in checks in this PR.
Expected behavior changes
Build, test, and run workflows runs functional tests. Uses cache to reduce build time.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal