Fix #338, Add MISRA Addons for cppcheck#339
Fix #338, Add MISRA Addons for cppcheck#339astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
ArielSAdamsNASA
force-pushed
the
fix-338-misra-addon-cppcheck
branch
from
7f5f250 to
a14e940
Compare
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
I don't think we are allowed to publish MISRA rules, also it looks like the check is just running against misra-test.c. I recommend starting with a local report and doing some analysis there prior to pushing it into CI...
ArielSAdamsNASA
force-pushed
the
fix-338-misra-addon-cppcheck
branch
from
a14e940 to
49dd75e
Compare
@skliper See new changes. Created a separate job for misra rules. Ran misra analysis against bundle, cfe, osal, and psp instead of misra-test.c. |
ArielSAdamsNASA
added
the
CCB:Ready
|
It's great work, I'm just concerned it may be a little premature to put into CI to run on every push from a project management perspective since we don't really have a plan in place with what to do with the actual results within the repo management process. Maybe make into an action that just gets triggered manually? |
ArielSAdamsNASA
force-pushed
the
fix-338-misra-addon-cppcheck
branch
from
49dd75e to
91c54eb
Compare
astrogeco
removed
the
CCB:Ready
|
Updated to trigger workflow manually. |
|
Sorry, I meant trigger the MISRA check as manual. The normal static analysis should still be in the normal push/merge flow since we do need to enforce it. |
So have a separate workflow for the misra analysis that runs manually? |
ArielSAdamsNASA
force-pushed
the
fix-338-misra-addon-cppcheck
branch
2 times, most recently
from
37d2d78 to
33e0c1e
Compare
ArielSAdamsNASA
force-pushed
the
fix-338-misra-addon-cppcheck
branch
from
33e0c1e to
6852d22
Compare
astrogeco
added
the
CCB:Approved
4 participants
Checklist (Please check before submitting)
Describe the contribution
Fixes #338
Testing performed
Tested on forked repo: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1143235812
Expected behavior changes
Runs MISRA rules for bundle, cfe, osal, and psp. Has a job for regular "clean" cppcheck and misra cppcheck.
Additional context
Future work includes:
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal