Fix #247, Move sample_libs into libraries dir#335
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Aug 17, 2021
Merged
Fix #247, Move sample_libs into libraries dir#335astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Set default branch for submodules in .gitmodules to "main"
Contributor
|
Consider postponing until Draco? Seems a bit unkind to break everyone's checked out bundle this late in the cycle. |
Contributor
|
Missing issue link. |
Contributor
Author
|
I think the only way it would break is if people have local "non-main" sample_lib branches |
astrogeco
added
the
CCB:Approved
Contributor
Author
|
CCB:2021-08-11 APPROVED
|
astrogeco
force-pushed
the
integration-candidate
branch
from
c2119ea to
94721a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Creates a new directory "libs" at the cFS bundle level to put libraries in. This will create a little more clarity between applications and libraries
Fixes #247
Testing performed
CI Ubuntu
Expected behavior changes
None, everything should still compile
System(s) tested on
Ubuntu 18.04
Additional context
Might require developers to fixup their local repos once change is merged