Fix #312, Generate Documentation In All Scenarios#316
Merged
astrogeco merged 3 commits intonasa:integration-candidatefrom Jul 29, 2021
Merged
Conversation
…d-Documentation-Workflow Fix nasa#310, No File Found Documentation Workflow Renamed jobs and steps for clarity Minor edits to step order in deploy jobs
ArielSAdamsNASA
added
the
CCB:Ready
ArielSAdamsNASA
force-pushed
the
fix-312-generate-documentation-in-all-scenarios
branch
2 times, most recently
from
2433f08 to
a00547b
Compare
ArielSAdamsNASA
force-pushed
the
fix-312-generate-documentation-in-all-scenarios
branch
from
a00547b to
99a13ba
Compare
astrogeco
suggested changes
Jul 27, 2021
ArielSAdamsNASA
force-pushed
the
fix-312-generate-documentation-in-all-scenarios
branch
from
99a13ba to
258f1df
Compare
ArielSAdamsNASA
force-pushed
the
fix-312-generate-documentation-in-all-scenarios
branch
from
258f1df to
1cb05f2
Compare
astrogeco
approved these changes
Jul 29, 2021
astrogeco
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #312
remove
if: ${{ github.event_name == 'push' && contains(github.ref, 'main')}}from PDF generation installs and PDF generation. Add PDF generation installs and PDF generation steps to the previous job, so that Deploy is a separate job.Testing performed
N/A
Expected behavior changes
PDFs will generate no matter what while deployment is based on if it is pushed on main.
Additional context
May require cache PR for successful deployment: #315
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal