Conversation
astrogeco
approved these changes
Jul 22, 2021
Contributor
|
@ArielSAdams could you squash? |
ac38528 to
d19ec3d
Compare
d19ec3d to
8dae824
Compare
Contributor
Author
Having issues trying to fix the conflicting files and squash them. |
Contributor
|
@ArielSAdamsNASA can you see if my fixes look right? |
Contributor
Author
Looks good! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #310
Workflow was failing due to files not persisting between jobs. Used cache action.
Testing performed
Tested on fork: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1057135024
Expected behavior changes
PDFs should generate.
Additional context
PDFs will generate when push on main branch.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal