Fix #251, Implement Coding Standard Rules in CodeQL#254
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom May 20, 2021
ArielSAdamsNASA:fix-251-jpl-rules-codeql
Merged
Fix #251, Implement Coding Standard Rules in CodeQL#254astrogeco merged 1 commit intonasa:integration-candidatefrom ArielSAdamsNASA:fix-251-jpl-rules-codeql
astrogeco merged 1 commit intonasa:integration-candidatefrom
ArielSAdamsNASA:fix-251-jpl-rules-codeql
Conversation
ArielSAdamsNASA
changed the title
ArielSAdamsNASA
changed the title
ArielSAdamsNASA
added
the
CCB:Ready
Contributor
|
Instead of a whole new workflow, you could do multiple jobs that use different config files |
astrogeco
added
CCB:Approved
Contributor
Author
@astrogeco The JPL and MISRA rules are added in the already existing configuration. There is no new workflow, just the codeql-build.yml workflow. Do you want me to add another configuration file and separate jobs, one for coding standard and one for security, in that one workflow? |
Contributor
I think that makes sense! |
astrogeco
force-pushed
the
integration-candidate
branch
from
da34c28 to
cbd1fe2
Compare
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Jan 12, 2026
…guide Fix nasa#241, Create EDS User Guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #251
Added JPL rules to configuration guide to follow the coding standard. CodeQL provides some MISRA rules scattered in its repository.
Testing performed
Tested locally. JPL rules can be seen here:
Expected behavior changes
CodeQL should scan for violations against JPL rules and a few MISRA rules.
Additional context
Can create a separate workflows. One for the coding standards and another for the security queries.
Note that users can search through results based on rules, but I believe this can be done one rule at a time.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal