Fix #205, Remove Duplicate Workflows#224
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 2, 2021
ArielSAdamsNASA:fix-205-remove_duplicate_workflows
Merged
Fix #205, Remove Duplicate Workflows#224astrogeco merged 1 commit intonasa:integration-candidatefrom ArielSAdamsNASA:fix-205-remove_duplicate_workflows
astrogeco merged 1 commit intonasa:integration-candidatefrom
ArielSAdamsNASA:fix-205-remove_duplicate_workflows
Conversation
ArielSAdamsNASA
added
CCB:Ignore
ArielSAdamsNASA
added
CCB:Ready
Contributor
|
CCB:2021-03-24 APPROVED |
astrogeco
added
IC:2021-03-30
and removed
CCB:Ready
astrogeco
approved these changes
Apr 2, 2021
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
I wonder if we should swap the duplicate so it skips the pull_request instead of the push triggers. I'll approve and merge though and we can examine later.
| jobs: | ||
|
|
||
| #Checks for duplicate actions. Skips push actions if there is a matching or duplicate pull-request action. | ||
| duplicate-job: |
Contributor
There was a problem hiding this comment.
Can we name this step "check-for duplicates"? We can open a new issue for this.
This was referenced Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #205
Removed the main branch in the static analysis, deprecated build, run, and test, and omit deprecated workflows for push. All four workflows, codeql, static analysis, deprecated build, run, and test, and omit deprecated uses a GitHub action to skip any duplication workflows.
Testing performed
Tested on my forked repository. Created a pull request and pushed changes to test.
Expected behavior changes
The static analysis, deprecated build, run, and test, and omit deprecated workflows now run on all branches when code is pushed. The codeql workflow already allowed this. The changes allow the workflows to run on all branches when users are wanting to test their commits on their forked repos.
The GitHub action used skips push workflows, instead of pull request workflows, and does not cause these skips to fail the checks. So, there should be no duplicate GitHub Actions Workflows.
Additional context
References: https://github.com/fkirc/skip-duplicate-actions/#skip-concurrent-workflow-runs, https://github.com/marketplace/actions/skip-duplicate-actions
Travis CI still runs for all push and pull requests and there are duplicate runs for this tool when tested on the forked repo pull request.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal