-
Notifications
You must be signed in to change notification settings - Fork 332
Description
Checklist (Please check before submitting)
- I reviewed the Contributing Guide.
- I reviewed the cFS README.md file to see if the feature is in the major future work.
- I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
The leading . isn't consistently applied (better to remove) and the non-strict/strict matrix doesn't really work right.
cFS/.github/workflows/static-analysis.yml
Line 54 in 963b3ab
| run: cppcheck --force --inline-suppr --std=c99 --language=c --enable=warning,performance,portability,style --suppress=variableScope --inconclusive .${{ inputs.strict-dir-list }} 2> ../${{matrix.cppcheck}}_cppcheck_err.txt |
Example:
strict-dir-list: './src/bsp ./src/os' as used in OSAL becomes ../src/bsp ./src/os which then misses the leading dir
The matrix runs all the steps in two workflows where only the upload is conditional. It still does both checks... really the checks are very fast so no need to split (already in separate steps so easy to see what fails).
Describe the solution you'd like
Remove matrix, remove leading . on strict directory list
Describe alternatives you've considered
None
Additional context
Will impact psp strict check nasa/PSP#333.
Requester Info
Jacob Hageman - NASA/GSFC