-
Notifications
You must be signed in to change notification settings - Fork 332
Closed
Labels
Milestone
Description
Checklist (Please check before submitting)
- I reviewed the Contributing Guide.
- I reviewed the cFS README.md file to see if the feature is in the major future work.
- I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
Historically, setting the Revision number to "99" indicates that the source code in question is a "development" version and thus hasn't been fully tested.
In nasa/osal#824, we put this information in the Mission_Rev instead and set it to "0xFF". This pattern has a couple of problems:
- It is not standard, cFE documentation needs to be updated
- If a user changes the MISSION_REV while building on top of a development version, there is no way to know what the original version was by looking at source code. (eg x.y.z.99 is changed by a user to x.y.z.100) kudos to @skliper for this observation
- Older telemetry or "ground" systems may be used to the two-character legacy number of "99" instead of "0xFF" and convert the value into a two-character string thereby cutting off the value.
Describe the solution you'd like
- Revert to using the Revision number
- Move from 99 to 0xff
- Communicate the change to users
Describe alternatives you've considered
Keep Revision = 99
Additional context
Need to open related Issues in other cFS component repositories
Requester Info
Gerardo Cruz-Ortiz, NASA
Reactions are currently unavailable