Merged
Conversation
Add a new typedef "CFE_ES_ResourceID_t" that can replace uint32 for all ID storage and manipulation. Initially this is just an alias to uint32 for backward compatibility. Convert all APIs that accept an ID to use the new typedef. This also reserves the value "0" as an undefined ID, and gives a separate base value for each resource type. Therefore even though the type is still uint32, the different resource IDs can still be distingushed.
Fix #894, add resource ID type
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Sep 29, 2020
Integration Candidate includes: nasa/cFE#916
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Sep 29, 2020
* IC: 20200929: Updating submodules to main. Integration Candidate includes: nasa/cFE#916
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #894
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/144/checks
Expected behavior changes
PR #896 - Add a new
typedef CFE_ES_ResourceID_tthat can replaceuint32for all ID storage and manipulation. Initially this is just an alias touint32for backward compatibility.System(s) tested on
Ubuntu - CI
Additional context
nasa/cFS#144
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.