Fix #897, EVS unregistered AppID#898
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Oct 1, 2020
Merged
Conversation
Do not use EventCount to track whether an "unregistered" event was generated, because that by definition came from a different app than the one that "owns" that field. This just adds a separate field to track that state, so it doesn't potentially modify the counter for an unrelated app.
jphickey
force-pushed
the
fix-897-evs-unreg-appid
branch
from
4ed1559 to
02b3a54
Compare
jphickey
added
the
CCB:Ready
Contributor
Author
|
Rebased to current main branch |
astrogeco
added
CCB-20200930
and removed
CCB:Ready
Contributor
|
CCB 2020-09-30: APPROVED |
Contributor
|
@jphickey do we need to document this new Unregistered "counter" somewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Do not overload the
EventCountfield to track whether an "unregistered" event was generated, which by definition comes from a different app than the one that might be actively using this same table entry.This just makes a separate field to track that state, leaving the
EventCountto serve its primary purpose of counting actual events generated from a valid/registered AppID.Fixes #897
Testing performed
Temporarily modified/hacked "sample_app" to send several events before calling
CFE_EVS_Register().Confirmed that one (and only one) "unregistered" event is reported e.g.:
Also confirmed that this "unregistered" event did not change the valid
EventCountin the EVS telemetry data.Expected behavior changes
No more incrementing a counter for another app.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.