Fix #886, library table id management#887
Fix #886, library table id management#887yammajamma merged 1 commit intonasa:integration-candidatefrom
Conversation
Apply the appid/taskid pattern to Library resources. No real logic change - just putting repeated logic into inline functions.
|
Also note that this cleans up a previously leftover debug |
jphickey
added
CCB:Ready
CDKnightNASA
left a comment
CDKnightNASA
left a comment
There was a problem hiding this comment.
I will create a ticket to define typedefs for ID's and return status codes. For now they can be simple typedefs to the uint32 type but eventually should be wrapped or otherwise we should have a mechanism to ensure that they're not misused.
Sounds good - this was on my eventual plans too. If you write tickets I only request they are separate ones (typedef for ids, typedef for returns) as each is a separate dev effort to do. |
|
CCB 2020-09-16 APPROVED |
yammajamma
added
CCB-20200916
and removed
CCB:Ready
5 participants
Describe the contribution
Apply the appid/taskid/counterid pattern to Library resources.
Testing performed
Build and sanity check CFE, ensure library is loaded correctly
Run all unit tests
Expected behavior changes
No impact to behavior. Internal change only.
System(s) tested on
Ubuntu 20.04
Additional context
Implement the same pattern on Library IDs which was previously implemented for apps, tasks, and counters.
For unit testing this also moves the Library-specific UT calls into a separate function.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.