Fix #796, Remove dependency on CCSDS version define#880
Merged
yammajamma merged 1 commit intonasa:integration-candidatefrom Sep 24, 2020
Merged
Fix #796, Remove dependency on CCSDS version define#880yammajamma merged 1 commit intonasa:integration-candidatefrom
yammajamma merged 1 commit intonasa:integration-candidatefrom
Conversation
- Removes MESSAGE_FORMAT_IS_CCSDS_VER2 and all references - Now replaced by MISSION_MSGID_V2 and MISSION_INCLUDE_CCSDS_HEADER cmake variables - Base MIDs localized to cpu1_msgids.h and improved documentation indicating example nature of implementation, note issue nasa#732 may make this obsolete - Updated cfe_sb.dox for message module concept - MsgId base type now always uint32 (reduces logic differences) - Removed system log report of version used, in build and obvious from packet sizes - Cleaned extra documentation from cfe_sb_msg_id_util.c - Removed verification limits on CFE_PLATFORM_SB_MAX_MSG_IDS - Removed UT_GetActualPktLenField and UT_GetActualCmdCodeField that depended on the define, shouldn't directly access message in a unit test since it's implementation dependent - Default CCSDS version default now always 0 (per the standard) but mission configurable
skliper
added
the
CCB:Ready
This was referenced Sep 11, 2020
Contributor
Author
|
Sample app unit test failure (nasa/sample_app#87) is fixed by nasa/sample_app#94. Should merge these together. |
Contributor
Author
|
I see this PR was missed last week. Another example of our failing process related to reviewing pull requests, which then lead to the breakage caused by nasa/sample_app#94. Not sure why we continue to utilize a process that continues to miss review-ready PRs. |
Contributor
|
CCB 2020-09-23 APPROVED |
yammajamma
added
CCB-20200923
and removed
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #796
cmake variables
indicating example nature of implementation, note issue MsgId abstraction - add API to translate between topic ID and MsgId #732
may make this obsolete
from packet sizes
that depended on the define, shouldn't directly access message
in a unit test since it's implementation dependent
but mission configurable
Testing performed
Build unit tests, passed except for sample app. Build usersguide and confirmed no errors or warnings.
Expected behavior changes
None, just no longer requires additional configuration flag
System(s) tested on
Additional context
#726
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC