HOTFIX-20200902, Fix sb unit test setup issue#866
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Sep 4, 2020
Merged
HOTFIX-20200902, Fix sb unit test setup issue#866astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Contributor
Author
|
@yammajamma @astrogeco - fixes nasa/cFS#136 CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix integration-candidate - there was some convoluted test setup logic which actually caused some of the tests to be skipped and the CleanApp API test wasn't proceeded by a test reset so the event count didn't match expected. Caused a TTF.
Basically just straightened out the setup (no actual test changes.)
Testing performed
Make, make test - passed
Expected behavior changes
Tests pass, no TTF.
System(s) tested on
Additional context
nasa/cFS#136
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC