Skip to content

Fix #836, Replace CFE_MISSION_SPACECRAFT_ID with CFE_PSP_GetSpacecraftId()#842

Merged
yammajamma merged 1 commit intonasa:integration-candidatefrom
skliper:fix836-spacecraft-id
Aug 26, 2020
Merged

Fix #836, Replace CFE_MISSION_SPACECRAFT_ID with CFE_PSP_GetSpacecraftId()#842
yammajamma merged 1 commit intonasa:integration-candidatefrom
skliper:fix836-spacecraft-id

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Aug 25, 2020

Describe the contribution
Fix #836 - replaced CFE_MISSION_SPACECRAFT_ID use with CFE_PSP_GetSpacecraftId() and updated unit test

Testing performed
Built version 2 with unit tests, executed and passed

Expected behavior changes
No longer uses soon to be deprecated CFE_MISSION_SPACECRAFT_ID

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle integration candidate + this change

Additional context
Depends on changes in integration candidate

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) enhancement labels Aug 25, 2020
@skliper skliper added this to the 7.0.0 milestone Aug 25, 2020
@astrogeco
Copy link
Contributor

CCB 2020-08-26 - APPROVED

@yammajamma yammajamma added CCB-20200826 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 26, 2020
@yammajamma yammajamma merged commit 2ab77d0 into nasa:integration-candidate Aug 26, 2020
@skliper skliper deleted the fix836-spacecraft-id branch February 1, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace msg module use of CFE_MISSION_SPACECRAFT_ID with CFE_PSP_GetSpacecraftId()

3 participants