Skip to content

Fix #818, Return message address from CFE_SB_SendMsg stub#834

Merged
yammajamma merged 1 commit intonasa:integration-candidatefrom
skliper:fix818-sendmsg-stub-rtn
Aug 26, 2020
Merged

Fix #818, Return message address from CFE_SB_SendMsg stub#834
yammajamma merged 1 commit intonasa:integration-candidatefrom
skliper:fix818-sendmsg-stub-rtn

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Aug 24, 2020

Describe the contribution
Fix #818, CFE_SB_SendMsg stub now behaves the same as CFE_SB_TimeStampMsg (copies message pointer from local)
Fix #825, No longer need to emulate CFE_SB_InitMsg from test code, set the API/stub data buffers directly.

Testing performed
Built with tests, tests ran and passed. Depends on update to unit test in sample_app, nasa/sample_app#90.

Expected behavior changes
Stub returns message address instead of copy of message.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle main (+cfe/osal main) + this commit.

Additional context
nasa/sample_app#90

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) enhancement labels Aug 24, 2020
@astrogeco
Copy link
Contributor

CCB 2020-08-26 - APPROVED

@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 26, 2020
@yammajamma yammajamma added IC-20200826 CCB:Approved Indicates code review and approval by community CCB labels Aug 26, 2020
@yammajamma yammajamma changed the base branch from main to integration-candidate August 26, 2020 17:52
@yammajamma yammajamma merged commit 5f01981 into nasa:integration-candidate Aug 26, 2020
@skliper skliper deleted the fix818-sendmsg-stub-rtn branch February 1, 2021 22:05
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB enhancement unit-test

Projects

None yet

3 participants