Fix #828, Spacecraft ID sample set to historical value (0x42)#829
Merged
astrogeco merged 1 commit intonasa:6.8.xfrom Sep 4, 2020
Merged
Fix #828, Spacecraft ID sample set to historical value (0x42)#829astrogeco merged 1 commit intonasa:6.8.xfrom
astrogeco merged 1 commit intonasa:6.8.xfrom
Conversation
Contributor
Author
|
May want to consider this one for inclusion in Bootes... since the previous change (where it went to 42 decimal) could be considered a "breaking" change. There are toolchains that depend on this historical value. Although it is just in the sample config settings, so easy enough to fix. Just won't work "out of the box" for folks with an expectation that it didn't change. |
skliper
added
CCB:Ready
CDKnightNASA
approved these changes
Aug 21, 2020
Contributor
CDKnightNASA
left a comment
CDKnightNASA
left a comment
There was a problem hiding this comment.
I say hotfix Bootes with this.
Contributor
|
CCB 2020-08-26 - APPROVED, add to Bootes and tag rc2 |
yammajamma
added
CCB-20200826
CCB:Approved
Contributor
|
Instructions for this merge:
|
Contributor
Author
|
I can rebase this on 6.8.x if you want. |
skliper
force-pushed
the
fix828-spacecraft-id-hex
branch
from
b15c4e5 to
1be664e
Compare
Contributor
Author
|
This one is good to go onto 6.8.x, I'll create the PR for 7.0 next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #828 - set spacecraft ID in sample targets.cmake to 0x42
Testing performed
Nominal build and test
Expected behavior changes
Spacecraft ID back to historical value (some toolchains depend on it). Verified at PSP startup, reported as 66 (0x42).
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC