Fix #795, Remove legacy time header format support#801
Merged
yammajamma merged 1 commit intonasa:integration-candidatefrom Aug 20, 2020
Merged
Fix #795, Remove legacy time header format support#801yammajamma merged 1 commit intonasa:integration-candidatefrom
yammajamma merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
enhancement
CCB:Ready
skliper
force-pushed
the
fix795-time-format
branch
from
55d0764 to
c039fb4
Compare
Contributor
|
CCB 2020-08-19 APPROVED, provide example for override. See idea in #726 |
yammajamma
added
CCB:Approved
skliper
force-pushed
the
fix795-time-format
branch
from
c039fb4 to
1582beb
Compare
Contributor
Author
|
Rebased on integration-candidate |
yammajamma
removed
the
CCB:Ready
astrogeco
added a commit
that referenced
this pull request
Aug 25, 2020
HOTFIX for #801 on IC-20200819: Deprecated time format verify logic fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #795
Fix #92
Collapses options down to just 32 bit second, 16 bit subsecond, always big endian. Removes old defines, and errors out if the configuration is set to a format that was removed.
Testing performed
Built and
make testwithSIMULATION=native ENABLE_UNIT_TESTS=true, passes test.Expected behavior changes
Time in header always big endian.
System(s) tested on
Additional context
#726
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC