Fix #265, implement cmake name based targets#776
Fix #265, implement cmake name based targets#776astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
|
Would it make sense to consider transitioning the platform and mission cfe config file into cmake, similar to osconfig? |
Yes, I think it would! Particularly for some of the CFE TIME options - these could then be different source files rather than But that's a fairly big change to existing paradigms obviously - probably should be a separate steering committee discussion. |
|
The msg module as currently drafted has started in this direction with source selection. Which is clumsy since the rest of cFE uses the header file config. |
|
CCB-2020-07-15 - Mark as deprecated for 7.0 |
astrogeco
force-pushed
the
integration-candidate
branch
3 times, most recently
from
7c34582 to
343f60d
Compare
Remove requirement to define a sequential/numbered list of targets. Instead, user defines a list of target names, followed by a set of properties associated with each name. This makes it much simpler to consistently define CPUs but selectively add/remove them from the build based on other criteria.
jphickey
force-pushed
the
fix-265-name-based-target
branch
from
83bf1d0 to
8afeb2a
Compare
|
Update - rebased to current main branch. Should be good to go. |
jphickey
added
the
CCB:Ready
|
CCB 2020-08-19 Might break CI-Lab, test at the bundle level |
astrogeco
added
build-system
and removed
CCB:Ready
3 participants
Describe the contribution
Allow targets to be configured in
targets.cmakeby name, rather than a numeric index. This is more user friendly, allows more configuration flexibility, and cleans up a bunch of extra logic too.Fixes #265
Testing performed
Build system, sanity check CFE, and run all unit tests
Testing not fully completed - Initially submitting PR for design review/feedback.
Expected behavior changes
No change to FSW, but changes the way targets are defined in
targets.cmake.This includes backward compatibility for existing files/configs, however.
System(s) tested on
Ubuntu 20.04
Additional context
Also related to #710, this cleans up hardcoded CPU IDs that were in the platform config header file.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.