Fix #774, do not generate empty include file#775
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jul 15, 2020
Merged
Fix #774, do not generate empty include file#775astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Report an error if no files are available to fulfill an include file requirement, rather than leaving an empty file.
Contributor
Author
|
Note to reviewers - this patch is against the current IC. It might be worth a fast track/hotfix? Not a major issue, but avoids a bit of a head scratcher if/when you mis-configure your |
skliper
approved these changes
Jul 10, 2020
CDKnightNASA
approved these changes
Jul 10, 2020
Contributor
CDKnightNASA
left a comment
There was a problem hiding this comment.
def have run into this personally and with other new users
astrogeco
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Detect the condition where no files were present to fulfill an config include file requirement, and report as an error rather than generating an empty file.
Fixes #774
Testing performed
Create a test config that refers to a nonexistent platform config called "foobar" by setting this in
targets.cmake:SET(TGT1_PLATFORM foobar)Without this change,
make prepstill (seemingly) completes successfully but thecfe_platform_cfg.his actually empty, which results in a later compiler error.Expected behavior changes
After applying this change, the issue is reported as a
make preperror instead, along with a list of files it checked for.Example:
No FSW changes - just reporting this configuration error.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.