Fix #752, use OS_READ_ONLY, not O_RDONLY#768
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Jul 6, 2020
Merged
Fix #752, use OS_READ_ONLY, not O_RDONLY#768astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Calls to OS_open() must use the OSAL-defined symbol, not the POSIX symbol. This was a long-standing bug but happened to work because they are both zero.
jphickey
added
the
CCB:Ready
Contributor
Author
|
@astrogeco , @skliper - I had meant to submit this one for yesterday's CCB. Trivial fix but I think important. Should we get this into 6.8.x cycle (i.e. fast track)? |
Contributor
|
Yes please. |
astrogeco
removed
the
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Calls to OS_open() must use the OSAL-defined symbol, not the POSIX symbol. This was a long-standing bug but happened to work because they are both zero.
Fixes #752
Testing performed
Build and sanity check CFE
Build and run unit tests
Expected behavior changes
None.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11.3
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.