Fix #747, Update CFE_SB_TimeStampMsg to save the message pointer argument#748
Merged
astrogeco merged 3 commits intonasa:integration-candidatefrom Jul 1, 2020
Merged
Conversation
Integration Candidate: 2020-05-27
Integration Candidate: 2020-06-10
… UT_Stub_CopyFromLocal so that unit tests can check it
skliper
approved these changes
Jun 22, 2020
jphickey
approved these changes
Jun 22, 2020
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Seems fine for the time being - but does remind me that we still need to do a scrub to make sure all args are available for hook functions
astrogeco
added
the
CCB:Ready
astrogeco
changed the title
astrogeco
added
CCB-20200624
and removed
CCB:Ready
Contributor
|
CCB-20200624: Approved |
astrogeco
added
the
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… UT_Stub_CopyFromLocal so that unit tests can check it
Describe the contribution
A clear and concise description of what the contribution is.
Fixes #747
Testing performed
Wrote test that failed when using original version of SB stub CFE_SB_TimeStampMsg.
[ FAIL] 01.001 cf_app_tests.c:90 - CFE_SB_TimeStampMsg received 0xc8230eadc0 and should be 0x61b180Changed to have stub UT_Stub_CopyFromLocal passed in argument.
[ PASS] 01.001 cf_app_tests.c:90 - CFE_SB_TimeStampMsg received 0x61b180 and should be 0x61b180Expected behavior changes
Passed in argument value is now available to a test that uses UT_SetDataBuffer for CFE_SB_TimeStampMsg.
System(s) tested on
Additional context
None.
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Alan Gibson, GSFC-0587