Merged
Conversation
Makes the SB unit test closer to recommended UT assert patterns Do not keep a separate "TestStat" state variable outside UT assert. Do not report separate status messages from the asserts. Use UT assert. Do not "reset" in the middle of a test routine, split into separate test routines where this is done. No need for "START" and "STARTBLOCK" or "ENDBLOCK". UT assert has messages for these test actions. Each block should be a separate test routine and then these are unnecessary.
Fix #734, continue cleanup of SB unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #734, continue cleanup of SB unit test
Testing performed
Bundle CI: https://github.com/nasa/cFS/pull/102/checks
Expected behavior changes
PR #737 - SB Unit use of the UT assert framework is closer to original design intent
System(s) tested on
Ubuntu:Bionic
Additional context
Part of nasa/cFS#102
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz, NASA-GSFC