Merged
Conversation
…flag as a possible return type.
Replace all direct references to data types defined in ccsds.h with the abstract type defined in cfe_sb.h
Add a va_list to capture the full set of variable arguments on all CFE_EVS event calls. Also add va_list for CFE_ES_WriteToSyslog
Fix #704, Added stub for CFE_SB_DeletePipe in ut_sb_stubs.c
Fix #603, Full context info for EVS event stubs
Fix #719, remove refs to ccsds data structures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #704
Fix #603
Fix #719
Testing performed
https://github.com/nasa/cFS/pull/96/checks
Expected behavior changes
PR #714 - API Change: cFE ut_sb_stubs now has CFE_SB_DeletePipe available.
Behavior Change: App unit tests requiring this will not fail to build due to undefined reference to
CFE_SB_DeletePipePR #713 - Hook functions may now use the
va_listform and obtain the full set of variable arguments passed toCFE_EVS_SendEventand variants.PR #725 - Replace all direct references to data types defined in
ccsds.hwith the abstract type defined incfe_sb.h.System(s) tested on
Ubuntu:Bionic
Additional context
Part of nasa/cFS#96
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Alan Gibson, NASA-GSFC