Fix #719, remove refs to ccsds data structures#725
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Jun 2, 2020
Merged
Fix #719, remove refs to ccsds data structures#725astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Integration Candidate 2020-05-13
Replace all direct references to data types defined in ccsds.h with the abstract type defined in cfe_sb.h
skliper
approved these changes
May 29, 2020
skliper
added
CCB:FastTrack
CCB:Ready
astrogeco
added
IC-20200527
CCB:Approved
astrogeco
added
CCB-20200212
and removed
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Replace all direct references to data types defined in
ccsds.hwith the abstract type defined incfe_sb.h.Fixes #719
Testing performed
Build and run CFE, sanity check, confirm all unit test pass.
Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 20.04
Additional context
There are similar changes to apps, too, which will be separate PRs (not submitted yet).
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.