Fix #603, Full context info for EVS event stubs#713
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Jun 2, 2020
Merged
Fix #603, Full context info for EVS event stubs#713astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Contributor
Author
Contributor
|
Are you planning another PR for CFE_ES_WriteToSysLog? |
skliper
approved these changes
May 21, 2020
Contributor
Author
See commit 4cbd761, will squash when I rebase. |
Integration Candidate 2020-05-13
astrogeco
added
the
CCB:Ready
Contributor
|
CCB 2020-05-27 APPROVED, @jphickey Create a new issue to refer to items by name. |
Contributor
astrogeco
removed
the
CCB:Ready
Contributor
|
@jphickey can I remove the draft label? |
astrogeco
added
the
CCB:Approved
Add a va_list to capture the full set of variable arguments on all CFE_EVS event calls. Also add va_list for CFE_ES_WriteToSyslog
jphickey
force-pushed
the
fix-603-add-evs-stub-args
branch
from
4cbd761 to
234da0a
Compare
Contributor
Author
|
@astrogeco Rebased to "master', should good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Create a va_list object to capture the full set of variable arguments passed to CFE_EVS_SendEvent and variants (TimedEvent, WithAppID). Use the variable argument form of the stub implementation to pass all info through to a (possible) hook function.
Fixes #603
Testing performed
Build all unit tests and confirm normal operation, all passing.
Expected behavior changes
Hook functions may now use the va_list form and obtain the full context info.
System(s) tested on
Ubuntu 20.04
Additional context
see also nasa/osal#479, nasa/sample_app#66 for other related enhancements.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.