Fix #676, reference to deprecated CFE_SPACECRAFT_ID#677
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom May 8, 2020
Merged
Conversation
Should be CFE_MISSION_SPACECRAFT_ID
jphickey
added
bug
CCB:Ready
skliper
added
CCB-20200506
and removed
CCB:Ready
Contributor
|
CCB 20200506 - Approved |
astrogeco
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Change to
CFE_MISSION_SPACECRAFT_ID, which is the non-deprecated symbol.Fixes #676
Testing performed
Build with extended header and
OMIT_DEPRECATEDand confirm success.Expected behavior changes
Build now works with both extended headers and OMIT_DEPRECATED options set.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.