Merged
Conversation
Implement CCSDS command secondary header such that it is endian agnostic in code and unit test support.
Document change only, updates the interrupt handler section to note OSAL deprecation
Fix #571, Update App Dev Guide Int Handler
Fix #297, CCSDS Command Secondary Header Endian Agnostic
Fix #569, Resolve CI warnings and add badge
astrogeco
changed the title
Replaces the `OS_IntLock` with a standard OSAL mutex for protecting the shared/global perflog data structure. This may introduce unexpected task switches when contention occurs, but it ensures proper exclusion with respect to the data structures. Removes the temporary child worker task that was spawned for writing the log data to a file, and replace with a more generic CFE ES background task. The background task is started at boot and pends on a semaphore until there is work to do. The background performance log dump is implemented as a state machine which is called repeatedly over time from the background job task. This performs a limited amount of work on each invocation, and resumes where it left from the previous invocation.
Fix #456, Perf log threading and concurrency issues
astrogeco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration Candidate
Fixes #297, #569, #456, and #571
Testing performed
See PRs
Bundle CI see nasa/cFS#64
Test Log: https://travis-ci.com/github/nasa/cFS/builds/159710339
Expected behavior changes
PR #568 - Cmd code (and checksum) are always in the same place (matches GSFC spec for command secondary header)
PR #570 - No Travis-CI configuration warnings
PR #572 - Document change only, updates the interrupt handler section to note OSAL deprecation
PR #595 - No impact to behavior. Previously the perf log dump file frequently contained errors due to out of order or otherwise corrupted entries, which is now fixed.
System(s) tested on
See PRs
Bundle CI - Ubuntu:Bionic
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz, NASA-GSFC