Fix #297, CCSDS Command Secondary Header Endian Agnostic#568
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 6, 2020
Merged
Fix #297, CCSDS Command Secondary Header Endian Agnostic#568astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Implement CCSDS command secondary header such that it is endian agnostic in code and unit test support.
skliper
added
the
CCB:Ready
Contributor
Author
|
@BaldBeacon @tngo67 - ping. *EDIT - tagged wrong person. |
Contributor
|
CCB 2020-04-01 - Discussed. Will break systems that are little endian as happened in a previous cFE version. Users who need this functionality can apply the diff. APPROVED |
astrogeco
added
CCB - 20200401
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implement CCSDS command secondary header such that it is endian agnostic in code and unit test support.
Fix #297
Testing performed
Steps taken to test the contribution:
This covered both direct cmdUtil call and cFS-GroundSystem use.
Expected behavior changes
Cmd code (and checksum) are always in the same place (matches GSFC spec for command secondary header)
System(s) tested on
Additional context
See also nasa/cFS-GroundSystem#66 these should be merged together
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC