Skip to content

Use SRC_LOCAL_PATH as single source of truth#458

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
matzipan:patch-2
Mar 18, 2020
Merged

Use SRC_LOCAL_PATH as single source of truth#458
astrogeco merged 1 commit intonasa:integration-candidatefrom
matzipan:patch-2

Conversation

@matzipan
Copy link
Contributor

@matzipan matzipan commented Jan 8, 2020

This avoids the two path diverging and possibly causing problems in the future

Describe the contribution
The call to file(TO_NATIVE_PATH ...) is building its own path even though its contents are identical to SRC_LOCAL_PATH. This change avoids possible divergence of these values in the future.

Testing performed
Ran a local build.

Expected behavior changes
No change in behavior.

@matzipan
Use SRC_LOCAL_PATH as single source of truth
08160ac 
This avoids the two path diverging and possibly causing problems in the future
jphickey
jphickey approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@skliper skliper added the CCB:PendingCLA External contribution pending CLA confirmation label Jan 22, 2020
@stanislaw
Copy link
Contributor

stanislaw commented Feb 20, 2020

Please note, that PTS GmbH has signed the corporate CLA document on Feb 17th and it has been sent to the GSFC-SoftwareRelease email. @matzipan is on the list so this PR should no longer be pending CLA.

cc @skliper

@skliper skliper removed the CCB:PendingCLA External contribution pending CLA confirmation label Mar 2, 2020
@skliper
Copy link
Contributor

skliper commented Mar 2, 2020

CLA confirmed, this pull request can proceed.

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 2, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Mar 10, 2020

@matzipan and @stanislaw please update the the title of your pull requests and your commits to use the following format:

Fix #ISSUE_NUMBER, Description

see other pull requests and commits in repository as an example.

@astrogeco astrogeco added this to the 6.8.0 milestone Mar 10, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Mar 11, 2020

CCB 20200311 - Approved

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation. and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Mar 13, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate March 18, 2020 12:31
@astrogeco astrogeco merged commit 7a3e8c3 into nasa:integration-candidate Mar 18, 2020
@astrogeco astrogeco mentioned this pull request Mar 18, 2020
Merged
@matzipan
Copy link
Contributor Author

matzipan commented Mar 20, 2020

Apologies for not having time to change the title format to Fix #ISSUE_NUMBER, Description. I'm guessing it might be a bit late now.

@astrogeco
Copy link
Contributor

astrogeco commented Mar 20, 2020

Apologies for not having time to change the title format to Fix #ISSUE_NUMBER, Description. I'm guessing it might be a bit late now.

No worries. We don't have a contribution guide up so you had no way to know in advance. In the future please open an issue and then the pull request to address it; this helps us build our version description document when we do our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jphickey jphickey jphickey approved these changes

+1 more reviewer

@skliper skliper skliper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation.

Projects

None yet

Milestone

Bootes

Development

Successfully merging this pull request may close these issues.

5 participants

@matzipan @stanislaw @skliper @astrogeco @jphickey