Fix #259, Update tone leap variable#453
Merged
skliper merged 1 commit intonasa:merge-20200108from Jan 10, 2020
Merged
Conversation
Contributor
|
Did you really test against 6.6.0a and 1.4.2a? I'd recommend testing against the bundle master (it's at 6.7.3 and OSAL 5.0.3 now), see the line printed at startup:
|
skliper
approved these changes
Jan 6, 2020
Contributor
Author
|
Thanks for the catch! I ran it against the correct version...it was just
a copy and paste error.
…On Mon, Jan 6, 2020 at 4:31 PM skliper ***@***.***> wrote:
Did you really test against 6.6.0a and 1.4.2a? I'd recommend testing
against the bundle master (it's at 6.7.3 and OSAL 5.0.3 now), see the line
printed at startup:
EVS Port1 42/1/CFE_ES 2: Versions:cFE 6.7.3.0, OSAL 5.0.3.0, PSP 1.4.1.0,
chksm 17082
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#453?email_source=notifications&email_token=AMOLWJ2JYYKQW7L6EKSKRODQ4OPMJA5CNFSM4KDKDB2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIG3JDY#issuecomment-571323535>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMOLWJYFQW4PSFITCFIM7Q3Q4OPMJANCNFSM4KDKDB2A>
.
|
skliper
reviewed
Jan 6, 2020
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Actually it looks like this is committing a permissions change, which should be reverted.
skliper
approved these changes
Jan 7, 2020
skliper
added
the
CCB:Approved
Contributor
|
CCB 20190108 - Reviewed and approved for integration candidate |
skliper
pushed a commit
that referenced
this pull request
Jan 14, 2020
Fix #259, Update tone leap variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #259
Testing performed
#undef CFE_PLATFORM_TIME_CFG_BIGENDIAN -->
#define CFE_PLATFORM_TIME_CFG_BIGENDIAN
with AtToneLeapSeconds.
make prep
make
make install
./core-cpu1
Expected behavior changes
The software will compile and run successfully.
System(s) tested on:
Oracle VM VirtualBox
OS: ubuntu-19.10
Version: cFE 6.7.3.0; OSAL 5.0.3.0; PSP 1.4.1.0
Additional context
None
Contributor Info
Dan Knutsen
GSFC/NASA