Fix #101, Always increment sequence counter#419
Merged
skliper merged 1 commit intonasa:ic-20200121from Jan 21, 2020
Merged
Conversation
skliper
changed the title
skliper
force-pushed
the
fix-101-seq_count
branch
from
9af4084 to
4e32599
Compare
skliper
reviewed
Jan 14, 2020
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Could remove or mark CFE_SB_UNSUBSCRIPTION_RPT_EID as no longer generated.
skliper
suggested changes
Jan 17, 2020
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Remove CFE_SB_UNSUBSCRIPTION_RPT_EID (I think this was the CCB decision?)
Contributor
Author
will do |
CDKnightNASA
force-pushed
the
fix-101-seq_count
branch
from
dad1a39 to
5b94321
Compare
Contributor
Author
|
I believe I've properly squashed the branch, removed the unused EID, added unit tests...anything else? FYI for me what worked: % git checkout branch |
skliper
approved these changes
Jan 21, 2020
Contributor
|
CCB 20200115 - Reviewed and approved for IC pending the changes already addressed above |
skliper
added
the
CCB:Approved
Adds logic and associated unit tests Removes no-longer-used EID
skliper
force-pushed
the
fix-101-seq_count
branch
from
5b94321 to
54fbccb
Compare
Contributor
|
Updated commit message (no code change) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Note that this means route entries will never be removed and unsubscribe messages will never be sent.
Testing performed
Built and ran the SB unit tests. All passed, with changes included in this pull req.
Expected behavior changes
Sequence ID's of messages should increment even when there's (currently) no subscribers to that message ID.
System(s) tested on:
Debian VM
Contributor Info
[email protected]