Fix #199, Update obj creation failure requirement#369
Conversation
058caf0 to
85d9340
Compare
jphickey
left a comment
There was a problem hiding this comment.
It looks like this changed the functional requirements doc from an MD to an HTML file?
Was this intentional?
|
It was the pandoc gfm (github flavored markdown) setting. |
|
I tried the standard markdown (--to markdown) and it didn't render the tables in a readable format on GitHub. Happy to supply it in whatever format people want, it's just an output from the tool and pandoc conversions. |
|
The version I see now is loaded with HTML tags, it is not markdown at all. Markdown is definitely preferred as it keeps things easily readable and editable with a standard text editor. Github display on the website is a secondary goal -- most people won't look at it that way. Rather, they will clone the git repo and open their local copy in an editor. That being said, I believe there is a way to do tables in github-flavored markdown, even if an automatic conversion isn't possible (can always write a one-off perl script to fix it). Even if not, I would rather see it as a simple (non-tabular) list but keep it as plain text. Right now I can't even see what the actual change was in this pull request, because the entire file is converted to HTML. |
|
Uploaded for consideration - *.csv (directly from tool), *.html (from tool with branding removed), .gfm (.html converted with pandoc -gfm), .md (.html converted with pandoc -markdown). |
939c555 to
6934452
Compare
|
Updated per CCB 2019/10/09 review (csv format chosen) |
Describe the contribution
Fixes #199, updates obj creation failure requirement to platform defined response
Testing performed
None - document update
Expected behavior changes
None
System(s) tested on:
None
Additional context
Platform defined response now matches cFS PSP model.
Note - Requirements transitioned to new tracking system with minor typo fixes throughout and new output format which changes every line. "Version tracking" is really accomplished in the requirements management tool, not the *.md file.
Contributor Info
Jacob Hageman - NASA/GSFC