Ensure table name length is consistent across CPUs#27
Merged
jphickey merged 1 commit intonasa:masterfrom Oct 23, 2019
Merged
Conversation
Contributor
|
Switched base branch to rc-6.7.0 until it gets merged so all those changes don't clutter this change. |
skliper
suggested changes
Sep 16, 2019
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Add verify check to enforce multiple of 4 on string length in table header.
skliper
added
the
CCB:Approved
To ensure consistency in the size of the CFE_TBL_FileHdr_t struct, this should be constrained to use only mission-scope definitions. Also simplifies the structure definitions by _NOT_ padding strings out to 32 bit multiples. The default size of the strings are already 32 bit multiples so this is just unnecessary complexity. There is also no major issue if not 32 bit aligned, as the compiler will add it automatically where needed. Add a note in the related cfe_mission_cfg.h descriptions to affected values, that these should be kept as a multiple of 4 to maintain alignment. Updated for 2019-09-16 code review: - Added compile-time verification that the configuration directives are actually multiples of 4.
jphickey
force-pushed
the
fix-25-tblname-lengths
branch
from
534904a to
8fe60c3
Compare
Contributor
Author
|
Commit 8fe60c3 contains the requested modifications |
skliper
approved these changes
Oct 8, 2019
jphickey
added a commit
that referenced
this pull request
Oct 11, 2019
dzbaker
pushed a commit
that referenced
this pull request
Jan 15, 2026
Update table implementation to use transaction state objects more consistently for logging and event reporting. The TxnState object provides a consistent way to get things like the access descriptor, the reg rec pointer, and the various IDs.
dzbaker
pushed a commit
that referenced
this pull request
Jan 15, 2026
Fix #27, use transaction info for events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
To ensure consistency in the size of the CFE_TBL_FileHdr_t struct, this should be constrained to use only mission-scope definitions.
Also simplifies the structure definitions by NOT padding strings out to 32 bit multiples. The default size of the strings are already 32 bit multiples so this is just unnecessary complexity. There is also no major issue if not 32 bit aligned, as the compiler will add it automatically where needed.
Add a note in the related cfe_mission_cfg.h descriptions to affected values, that these should be kept as a multiple of 4 to maintain alignment.
Fixes #25
Testing performed
Built CFE using default/sample config
Verified no build issues, CFE and unit tests all run as expected (no change).
Expected behavior changes
No impact to behavior, but this may change the size of telemetry packets in some cases depending on the mission config.
System(s) tested on:
Ubuntu 18.04 (64 bit)
Contributor Info
Full name and company/organization of all contributors (required for acceptance)
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted