Fix #2379, implement SB bulk transfer test#2380
Merged
Conversation
Add a functional test that moves a large number of messages across the bus as fast as possible (i.e. with no delay). The process is timed, thus offering some metric as to the single thread/single core performance of the software bus implementation underneath. Note that due to vast differences between hardware, results should only be compared between successive runs on the exact same hardware, such as before and after a change was made.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| static const CFE_SB_MsgId_t CFE_FT_CMD_MSGID = CFE_SB_MSGID_WRAP_VALUE(CFE_TEST_CMD_MID); | ||
| static const CFE_SB_MsgId_t CFE_FT_TLM_MSGID = CFE_SB_MSGID_WRAP_VALUE(CFE_TEST_HK_TLM_MID); | ||
|
|
||
| void TestBulkTransmitRecv(void) |
Check notice
Code scanning / CodeQL
Function too long
| * This test procedure should be agnostic to specific MID values, but it should | ||
| * not overlap/interfere with real MIDs used by other apps. | ||
| */ | ||
| static const CFE_SB_MsgId_t CFE_FT_CMD_MSGID = CFE_SB_MSGID_WRAP_VALUE(CFE_TEST_CMD_MID); |
Check notice
Code scanning / CodeQL
Variable scope too large
| * not overlap/interfere with real MIDs used by other apps. | ||
| */ | ||
| static const CFE_SB_MsgId_t CFE_FT_CMD_MSGID = CFE_SB_MSGID_WRAP_VALUE(CFE_TEST_CMD_MID); | ||
| static const CFE_SB_MsgId_t CFE_FT_TLM_MSGID = CFE_SB_MSGID_WRAP_VALUE(CFE_TEST_HK_TLM_MID); |
Check notice
Code scanning / CodeQL
Variable scope too large
| static const CFE_SB_MsgId_t CFE_FT_CMD_MSGID = CFE_SB_MSGID_WRAP_VALUE(CFE_TEST_CMD_MID); | ||
| static const CFE_SB_MsgId_t CFE_FT_TLM_MSGID = CFE_SB_MSGID_WRAP_VALUE(CFE_TEST_HK_TLM_MID); | ||
|
|
||
| void TestBulkTransmitRecv(void) |
Check notice
Code scanning / CodeQL
Long function without assertion
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Add a functional test that moves a large number of messages across the bus as fast as possible (i.e. with no delay). The process is timed, thus offering some metric as to the single thread/single core performance of the software bus implementation underneath.
Note that due to vast differences between hardware, results should only be compared between successive runs on the exact same hardware, such as before and after a change was made.
Fixes #2379
Testing performed
Execute test before and after changes made
Expected behavior changes
Introduce some form of performance check for SB implementation
System(s) tested on
Debian
Additional context
The test itself only shows microseconds elapsed (because this metric is available from the PSP today) but the software can also be run under an external profiling tool for more info.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.