Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ** needing a fully-fledged implementation of printf in the OS_printf stub. | ||
| */ | ||
| static int UT_StrCmpFormatStr(const char *FormatStr, const char *TestStr, uint32 FormatLength, uint32 TestLength) | ||
| static int UT_StrCmpFormatStr(const char *FormatStr, const char *TestStr, size_t FormatLength, size_t TestLength) |
Check notice
Code scanning / CodeQL
Function too long
| ** Set the CDS size returned by the BSP | ||
| */ | ||
| uint8 *UT_SetCDSSize(int32 Size) | ||
| uint8 *UT_SetCDSSize(size_t Size) |
Check notice
Code scanning / CodeQL
Long function without assertion
| ** Set the size of the ES reset area | ||
| */ | ||
| void UT_SetSizeofESResetArea(int32 Size) | ||
| void UT_SetSizeofESResetArea(size_t Size) |
Check notice
Code scanning / CodeQL
Long function without assertion
| ** needing a fully-fledged implementation of printf in the OS_printf stub. | ||
| */ | ||
| static int UT_StrCmpFormatStr(const char *FormatStr, const char *TestStr, uint32 FormatLength, uint32 TestLength) | ||
| static int UT_StrCmpFormatStr(const char *FormatStr, const char *TestStr, size_t FormatLength, size_t TestLength) |
Check notice
Code scanning / CodeQL
Long function without assertion
| } | ||
|
|
||
| void ES_UT_SetupCDSGlobal(uint32 CDS_Size) | ||
| void ES_UT_SetupCDSGlobal(size_t CDS_Size) |
Check notice
Code scanning / CodeQL
Long function without assertion
| UT_SetHookFunction(UT_KEY(CFE_SB_TransmitMsg), NULL, NULL); | ||
| } | ||
|
|
||
| static void UT_EVS_DoDispatchCheckEvents(void *MsgPtr, uint32 MsgSize, UT_TaskPipeDispatchId_t DispatchId, |
Check notice
Code scanning / CodeQL
Long function without assertion
zbarnett
reviewed
Feb 16, 2024
| CFE_EVS_SendEvent(CFE_ES_ALL_APPS_EID, CFE_EVS_EventType_DEBUG, | ||
| "App Info file written to %s, Entries=%d, FileSize=%d", QueryAllFilename, (int)EntryCount, | ||
| (int)FileSize); | ||
| "App Info file written to %s, Entries=%d, FileSize=%lu", QueryAllFilename, (int)EntryCount, |
There was a problem hiding this comment.
This could be %zu and then you wouldn't have to cast FileSize at all.
Contributor
There was a problem hiding this comment.
Problem is not all "c99" compilers recognize %zu yet.... Once we update to C11 then we should be able to use the z modifier. For now I prefer to keep the cast to unsigned long.
jphickey
approved these changes
May 23, 2024
| CFE_EVS_SendEvent(CFE_ES_ALL_APPS_EID, CFE_EVS_EventType_DEBUG, | ||
| "App Info file written to %s, Entries=%d, FileSize=%d", QueryAllFilename, (int)EntryCount, | ||
| (int)FileSize); | ||
| "App Info file written to %s, Entries=%d, FileSize=%lu", QueryAllFilename, (int)EntryCount, |
Contributor
There was a problem hiding this comment.
Problem is not all "c99" compilers recognize %zu yet.... Once we update to C11 then we should be able to use the z modifier. For now I prefer to keep the cast to unsigned long.
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Anh Van <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Anh Van <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Anh Van <[email protected]>
thnkslprpt
deleted the
fix-2375-use-size-t-for-size-variables-and-parameters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
size_tfor variables/parameters representing size #2375size_twhere appropriateTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Some signed variables changed to unsigned but it would have been illogical/impossible to input negative values in those cases.
Contributor Info
Avi Weiss @thnkslprpt