Fix #2183, use osal_public_api header targets in doc#2184
Merged
Conversation
Ensure that `osal_public_api_headerlist` is a dependency of all the doc builds. Also adds the OSAL top level directory to the mission build which will define the `osal_public_api` target, and thus not require the path to be repeated.
dzbaker
added
CCB:Ready
dzbaker
approved these changes
Oct 25, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 26, 2022
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Haven Carlson <[email protected]>
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 26, 2022
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Haven Carlson <[email protected]>
dzbaker
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Ensure that
osal_public_api_headerlistis a dependency of all the doc builds. Also adds the OSAL top level directory to the mission build which will define theosal_public_apitarget, and thus not require the path to be repeated.Fixes #2183
Testing performed
Build documentation from clean build area
Expected behavior changes
Order of operations with doc targets does not matter anymore, as the file gets generated correctly no matter which target is built first.
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.