cFE Integration Candidate: Caelum-rc4+dev23#2161
Merged
Conversation
Propagates variable CMAKE_EXPORT_COMPILE_COMANDS to the cmake subprocess in mission_build.cmake
…rt_compile_commands Fix #2144, Propagate CMAKE_EXPORT_COMPILE_COMMANDS variable
…s-ignore Fix #2147, Remove CodeQL Paths Ignore
Fix #1460, Duplicated Logic in CFE_SB_BroadcastBufferToRoute
Fix #1540, Remove 'return;' from last line of void functions.
Fix #2153, Remove unnecessary parentheses around return values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
PR #2145
PR #2148
PR #2151
CFE_SB_BroadcastBufferToRoute#1460, Duplicated Logic in CFE_SB_BroadcastBufferToRoutePR #2156
PR #2154
Testing performed
cFE checks https://github.com/nasa/cFE/pull/2161/checks
cFS Bundle checks https://github.com/nasa/cFS/pull/586/checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
@aliounis
@thnkslprpt
@ArielSAdamsNASA