Fix #2095, Automatic suppression of flooding events#2117
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 29 potential problems in the proposed changes. Check the Files changed tab for more details.
| ** \par Limits | ||
| ** This number must be less than or equal to INT_MAX/1000 | ||
| */ | ||
| #define CFE_PLATFORM_EVS_MAX_APP_EVENT_BURST 16 |
There was a problem hiding this comment.
Do we want this feature enabled by default?
skliper
added
the
CCB:Ready
|
@jhnphm - this is planned for CCB on 8/3. Could you review the recent minor changes? Thanks for putting this together! |
jhnphm
left a comment
jhnphm
left a comment
There was a problem hiding this comment.
Suggesting the following changes to make the test code more robust against adjustments to CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC
…ent suppression
dzbaker
added
CCB:Approved
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
5 participants
Checklist (Please check before submitting)
Describe the contribution
Testing performed
CI
Expected behavior changes
Squelches flooding events (configurable)
System(s) tested on
CI
Additional context
Still a work in progress, needs coverage and functional cleanup
Third party code
None, update suggestion from NASA/JSC context.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC
Ping @jhnphm