Fix #2084, Add support for fractional seconds in epoch#2088
Merged
Fix #2084, Add support for fractional seconds in epoch#2088
Conversation
astrogeco
added
the
CCB:Ready
skliper
approved these changes
Apr 19, 2022
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
It "looks" fine but I haven't tried working through all the edge cases.
astrogeco
removed
the
CCB:Ready
Contributor
|
CCB:2022-04-20 APPROVED with Changes
|
astrogeco
added
the
CCB:Approved
Contributor
|
@dmknutsen do we need to update CTF scripts for this? |
jonathan-brandenburg-metecs
force-pushed
the
main
branch
from
8fece66 to
f5835d9
Compare
Contributor
|
Shouldn't require an update to any scripts - but will effect how we interpret/display time in the plugins...I'll update an push this week. |
Contributor
|
Workflow confirmed format fix, thx @jonathan-brandenburg-metecs! |
astrogeco
added a commit
that referenced
this pull request
May 2, 2022
Fix #2084, Add support for fractional seconds in epoch
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 2, 2022
*cFE* nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]>
astrogeco
added a commit
that referenced
this pull request
May 2, 2022
Fix #2084, Add support for fractional seconds in epoch Apply clang-format
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 2, 2022
*cFE* nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]>
This was referenced May 2, 2022
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
May 4, 2022
*cFE* nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]>
Contributor
|
@jonathan-brandenburg-metecs have you filled out a coporate CLA? |
I'll take care of it |
As I think about it, this submission was done under a NASA task order: SASS-80JSC020D0060-METECS SASS TO 28 - ER6 Gateway CFS Cert FY2 Thus NASA already "owns" my contribution. |
astrogeco
removed
the
CCB:PendingCLA
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 18, 2022
Combines nasa/cFE#2098, v7.0.0-rc4+dev127 nasa/osal#1251, v6.0.0-rc4+dev74 nasa/PSP#343, v1.6.0-rc4+dev34 **cFE** nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch nasa/cFE#2044, Remove redundant word in App Developers Guide nasa/cFE#2099, UT updates for alternate time configuration **RTEMS 6 Support nasa/cFE#2097, update rtems toolchain files nasa/osal#1250, add os-impl-no-select.c for RTEMS nasa/PSP#339, Update RTEMS CMake Platform File **PSP** nasa/PSP#341, Add cpu affinity example **Fix Broken CodeQL Workflow Reference** nasa/PSP#337 nasa/osal#1249 nasa/sample_lib#82 nasa/sample_app#173 nasa/sch_lab#113 nasa/ci_lab#109 nasa/to_lab#120 nasa/elf2cfetbl#110 nasa/tblCRCTool#68 nasa/cFS-GroundSystem#214 Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]> Co-authored-by: Alan Cudmore <[email protected]> Co-authored-by: Hugo Valente <[email protected]>
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 18, 2022
Combines nasa/cFE#2098, v7.0.0-rc4+dev127 nasa/osal#1251, v6.0.0-rc4+dev74 nasa/PSP#343, v1.6.0-rc4+dev34 **cFE** nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch nasa/cFE#2044, Remove redundant word in App Developers Guide nasa/cFE#2099, UT updates for alternate time configuration **RTEMS 6 Support nasa/cFE#2097, update rtems toolchain files nasa/osal#1250, add os-impl-no-select.c for RTEMS nasa/PSP#339, Update RTEMS CMake Platform File **PSP** nasa/PSP#341, Add cpu affinity example **Fix Broken CodeQL Workflow Reference** nasa/PSP#337 nasa/osal#1249 nasa/sample_lib#82 nasa/sample_app#173 nasa/sch_lab#113 nasa/ci_lab#109 nasa/to_lab#120 nasa/elf2cfetbl#110 nasa/tblCRCTool#68 nasa/cFS-GroundSystem#214 Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]> Co-authored-by: Alan Cudmore <[email protected]> Co-authored-by: Hugo Valente <[email protected]>
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2022
Combines nasa/cFE#2098, v7.0.0-rc4+dev127 nasa/osal#1251, v6.0.0-rc4+dev74 nasa/PSP#343, v1.6.0-rc4+dev34 **cFE** nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch nasa/cFE#2044, Remove redundant word in App Developers Guide nasa/cFE#2099, UT updates for alternate time configuration **RTEMS 6 Support nasa/cFE#2097, update rtems toolchain files nasa/osal#1250, add os-impl-no-select.c for RTEMS nasa/PSP#339, Update RTEMS CMake Platform File **PSP** nasa/PSP#341, Add cpu affinity example **Fix Broken CodeQL Workflow Reference** nasa/PSP#337 nasa/osal#1249 nasa/sample_lib#82 nasa/sample_app#173 nasa/sch_lab#113 nasa/ci_lab#109 nasa/to_lab#120 nasa/elf2cfetbl#110 nasa/tblCRCTool#68 nasa/cFS-GroundSystem#214 Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]> Co-authored-by: Alan Cudmore <[email protected]> Co-authored-by: Hugo Valente <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #2084
Testing performed
Build/run unit tests, confirm same coverage of time module
Expected behavior changes
Epoch contains a value for fractional seconds in the form of a CFE_MISSION_TIME_EPOCH_MICROS. This value is included in the time value before generating the printable string in CFE_TIME_Print
System(s) tested on
Hardware: i7/Virtual Box
OS: CentOS Linux 7.9
Versions: Bundle main plus this component
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jonathan Brandenburg - NASA/JSC