Skip to content

Fix #2055, Refactor doxygen mainpage into frontpage#2058

Merged
astrogeco merged 1 commit intonasa:mainfrom
skliper:fix2055-doxygen_frontpage
Mar 8, 2022
Merged

Fix #2055, Refactor doxygen mainpage into frontpage#2058
astrogeco merged 1 commit intonasa:mainfrom
skliper:fix2055-doxygen_frontpage

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Feb 23, 2022

Describe the contribution

Testing performed
Built doc, usersguide, osalguide and confirmed layout/contents

Expected behavior changes
None

System(s) tested on

Additional context
Hard to pull apart from #2052, so submitted on top. 30a4c4e is the subject of this merge. Will fail until #2052 dependencies are merged.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Feb 23, 2022
@skliper skliper added this to the Draco milestone Feb 23, 2022
@skliper
Copy link
Contributor Author

skliper commented Feb 24, 2022

Ping @jia-j-lin

@jia-j-lin
Copy link

jia-j-lin commented Feb 24, 2022

Ping @jia-j-lin

Thanks! Adding comment so I can be added as reviewer. @skliper

@astrogeco
Copy link
Contributor

astrogeco commented Mar 1, 2022

Ping @jia-j-lin

Thanks! Adding comment so I can be added as reviewer. @skliper

Looks like we have to add you as a member of the nasa org; complete 🔒 this NAMS Request and select the "cFS" team

@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 2, 2022
@jia-j-lin
Copy link

Ping @jia-j-lin

Thanks! Adding comment so I can be added as reviewer. @skliper

Looks like we have to add you as a member of the nasa org; complete 🔒 this NAMS Request and select the "cFS" team

Thank you. I just submitted the request and waiting for approval now.

Copy link

@jia-j-lin jia-j-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes to cfe_frontpage.dox and it looks good to me.

astrogeco added a commit that referenced this pull request Mar 6, 2022
Fix #2055, Refactor doxygen mainpage into frontpage
astrogeco added a commit to nasa/cFS that referenced this pull request Mar 6, 2022
Refactor doxygen mainpage into frontpage

- nasa/osal#1228
- nasa/cFE#2058
@skliper skliper force-pushed the fix2055-doxygen_frontpage branch from 74d209b to 68fb06e Compare March 7, 2022 16:04
astrogeco added a commit to nasa/cFS that referenced this pull request Mar 7, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Mar 8, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Mar 8, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Mar 8, 2022
@astrogeco astrogeco merged commit 4438f72 into nasa:main Mar 8, 2022
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Mar 16, 2022
@skliper skliper deleted the fix2055-doxygen_frontpage branch April 19, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB draco-rc1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doxygen mainpage if needed should not contain unique content, just references

3 participants