cFE Integration candidate: Caelum+dev3#2043
Merged
Conversation
If no return value override is set test against CFE_SB_INVALID_MSG_ID
Fix #2036, Revert breaking change to CFE_ES_AppInfo_t structure
- Add new parameters to match updated cFS-CodeQL workflow interface introduced in nasa/cFS#413 - Add file-exclusion checks to Action trigger so workflow doesn't run if only changes in commit or pull request are to documentation
…vement Fix #2040, Improve CFE_SB_IsValidMsgId handler
…macro Fix #2039, Replace CFE_SB_ValueToMsgId(0) with CFE_SB_INVALID_MSG_ID
Fix #2034, Update CodeQL workflow
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
PR #2042
PR #2041
CFE_SB_IsValidMsgIdhandler default behavior fails if return not set #2040, Improve CFE_SB_IsValidMsgId handlerPR #2037
PR #2035
Expected behavior changes
See PRs
Testing performed
cFE Checks https://github.com/nasa/cFE/pull/2043/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/414/checks
Note that CodeQL workflow will fail until nasa/cFS#414 is merged. Passing test can be seen in #2035
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#414
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@skliper