Merged
Conversation
astrogeco
force-pushed
the
fix-codeql-workflow
branch
3 times, most recently
from
46eddc3 to
b31f405
Compare
astrogeco
added
the
CCB:Ready
|
I will approve once the commits are fixed so the only change is the codeql workflow yml file. Instead of using |
astrogeco
force-pushed
the
fix-codeql-workflow
branch
2 times, most recently
from
1d64681 to
6bdb77e
Compare
Contributor
Author
Good catch! I just rebased it to remove the extraneous commits. Once the CI passes I'll update the tag to the nasa one. Can you look at nasa/cFS#413? |
astrogeco
force-pushed
the
fix-codeql-workflow
branch
2 times, most recently
from
4a3d05a to
7fbc58e
Compare
2 tasks
Contributor
Author
|
Converted to draft until cFS-level PR is merged |
astrogeco
force-pushed
the
fix-codeql-workflow
branch
from
7fbc58e to
43de2bf
Compare
astrogeco
removed
the
CCB:Ready
Contributor
Author
|
CCB:2022-01-27 APPROVED |
astrogeco
added
the
CCB:Approved
- Add new parameters to match updated cFS-CodeQL workflow interface introduced in nasa/cFS#413 - Add file-exclusion checks to Action trigger so workflow doesn't run if only changes in commit or pull request are to documentation
astrogeco
force-pushed
the
fix-codeql-workflow
branch
from
b875b15 to
81b3a9c
Compare
This was referenced Feb 23, 2022
This was referenced Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Depends on nasa/cFS#413
Fixes #2034
directory location
Testing performed
See PR checks Tab
Expected behavior changes
CodeQL Action executes successfully.
System(s) tested on
Additional context
None
Contributor Info - All information REQUIRED for consideration of pull request
Gerardo E. Cruz-Ortiz, NASA