Skip to content

Fix #1957, Functional CRC converted to MIR to handle different implementations#1958

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix1957-func_crc
Sep 21, 2021
Merged

Fix #1957, Functional CRC converted to MIR to handle different implementations#1958
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix1957-func_crc

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Sep 16, 2021

Describe the contribution

Testing performed
MCP750 (and CI)

Expected behavior changes
Functional CRC tests no longer fail vs hard coded values

System(s) tested on

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 16, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 16, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate September 21, 2021 14:59
@astrogeco astrogeco merged commit 596e977 into nasa:integration-candidate Sep 21, 2021
@astrogeco astrogeco added functional and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 22, 2021
@astrogeco
Copy link
Contributor

CCB:2021-09-21 APPROVED

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Sep 22, 2021
@skliper skliper deleted the fix1957-func_crc branch October 22, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB functional

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functional test crc results are implementation (and possibly endian) dependent, fail vs hard coded expected value

3 participants