Skip to content

Fix #1757, Handle fail status from internal functions of CFE_MSG_GetT…#1758

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
zanzaben:fix1757_handle_fail_codes_GetTypeFromMsgId
Aug 4, 2021
Merged

Fix #1757, Handle fail status from internal functions of CFE_MSG_GetT…#1758
astrogeco merged 1 commit intonasa:integration-candidatefrom
zanzaben:fix1757_handle_fail_codes_GetTypeFromMsgId

Conversation

@zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Aug 4, 2021

Describe the contribution
Fixes #1757
Handle fail status from internal functions of CFE_MSG_GetTypeFromMsgId

Testing performed
Build and run unit test

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 4, 2021
@skliper skliper added this to the 7.0.0 milestone Aug 4, 2021
@astrogeco
Copy link
Contributor

Can you truncate the commit message ?

@zanzaben zanzaben force-pushed the fix1757_handle_fail_codes_GetTypeFromMsgId branch from 0b45436 to 6cf2e2f Compare August 4, 2021 14:37
@astrogeco astrogeco changed the base branch from main to integration-candidate August 4, 2021 15:08
@astrogeco astrogeco merged commit a434d6c into nasa:integration-candidate Aug 4, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Aug 4, 2021

CCB:2021-08-04 APPROVED

  • Replace int32 with cfe_status_t
    • Add as a hotfix to integration-candidate

@zanzaben zanzaben deleted the fix1757_handle_fail_codes_GetTypeFromMsgId branch August 18, 2021 13:50
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 25, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Aug 25, 2021

CCB:2021-08-25

  • Do we need to update a test for this?
  • @skliper open issue for catching this in coverage tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CFE_MSG_GetTypeFromMsgId not handling all invalid inputs

3 participants