Fix #813, Add Generic Counter API test#1753
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Aug 9, 2021
Merged
Fix #813, Add Generic Counter API test#1753astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Add tests for the following APIs: CFE_ES_RegisterGenCounter CFE_ES_CounterID_ToIndex CFE_ES_GetGenCounterIDByName CFE_ES_GetGenCounterName CFE_ES_GetGenCount CFE_ES_SetGenCount CFE_ES_IncrementGenCounter CFE_ES_DeleteGenCounter
jphickey
force-pushed
the
fix-813-counter-tests
branch
from
e0cb579 to
33f66a9
Compare
Contributor
Author
|
This also depends on nasa/osal#1125, which is why CI is failing right now. Once the next OSAL merge cycle is complete should be able to re-run CI and confirm success.... |
jphickey
added
the
CCB:Ready
zanzaben
previously requested changes
Aug 3, 2021
Contributor
zanzaben
left a comment
zanzaben
left a comment
There was a problem hiding this comment.
Every test should have a UtPrintf("Testing: ..."); at the top stating which functions are being tested.
skliper
approved these changes
Aug 4, 2021
Contributor
|
CCB:2021-08-04 APPROVED with CHANGES
|
astrogeco
added
CCB:Approved
At UtPrintf statements to indicate the APIs that the test is focused on.
Contributor
Author
|
Removing dependency label, as the required change is now in OSAL main branch, everything should be fine to merge normally now. |
zanzaben
reviewed
Aug 9, 2021
| UtAssert_UINT32_LT(Idx, CFE_PLATFORM_ES_MAX_GEN_COUNTERS); | ||
|
|
||
| /* Confirm proper rejection of bad args in CFE_ES_CounterID_ToIndex */ | ||
| UtAssert_INT32_EQ(CFE_ES_CounterID_ToIndex(CFE_ES_COUNTERID_UNDEFINED, &Idx), CFE_ES_ERR_RESOURCEID_NOT_VALID); |
Contributor
There was a problem hiding this comment.
CFE_ES_CounterID_ToIndex is being tested by #1716 so you don't need to check it here.
Contributor
Author
There was a problem hiding this comment.
Yeah, we wrote these tests in parallel. I don't see a real problem with testing it in two places, as they are slightly different variations. It doesn't hurt anything.
Contributor
There was a problem hiding this comment.
alright just wanted to make sure we were aware.
zanzaben
approved these changes
Aug 9, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 9, 2021
- nasa/cFE#1734, Add table api functional tests - nasa/cFE#1753, Add Generic Counter API test
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 11, 2021
**Combines** - nasa/cFE#1772, v6.8.0-rc1+dev844 - nasa/osal#1127, v5.1.0-rc1+dev590 **Includes** *cFE* - nasa/cFE#1737, Move global count into test global struct. - nasa/cFE#1722, Add ES application control API functional tests - nasa/cFE#1743, Update coverage test to use UtAssert macros - nasa/cFE#1734, Add table api functional tests - nasa/cFE#1753, Add Generic Counter API test - nasa/cFE#1766, finish ES misc API functional test - nasa/cFE#1764, last char truncated in coverage log output - nasa/cFE#1728, Mistakes in some copyright headers - nasa/cFE#1767, Add misc time api functional test cFE - nasa/cFE#1749, Add Functional Test for EVS Reset Filters API - nasa/cFE#1781, RTEMS CFE_FT_Global build failure - nasa/cFE#1796, replace VOIDCALL assert macro *osal* - nasa/osal#1117, Add absolute branch coverage check
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 11, 2021
**Combines** - nasa/cFE#1772, v6.8.0-rc1+dev844 - nasa/osal#1127, v5.1.0-rc1+dev590 **Includes** *cFE* - nasa/cFE#1737, Move global count into test global struct. - nasa/cFE#1722, Add ES application control API functional tests - nasa/cFE#1743, Update coverage test to use UtAssert macros - nasa/cFE#1734, Add table api functional tests - nasa/cFE#1753, Add Generic Counter API test - nasa/cFE#1766, finish ES misc API functional test - nasa/cFE#1764, last char truncated in coverage log output - nasa/cFE#1728, Mistakes in some copyright headers - nasa/cFE#1767, Add misc time api functional test cFE - nasa/cFE#1749, Add Functional Test for EVS Reset Filters API - nasa/cFE#1781, RTEMS CFE_FT_Global build failure - nasa/cFE#1796, replace VOIDCALL assert macro *osal* - nasa/osal#1117, Add absolute branch coverage check Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add tests for the following APIs:
Fixes #813
Testing performed
Build and run all functional tests, confirm passing
Expected behavior changes
Additional APIs are tested
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.