Fix #1743, update coverage test to use UtAssert macros#1744
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Aug 9, 2021
Merged
Fix #1743, update coverage test to use UtAssert macros#1744astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
A number of CFE coverage-specific macros and generic assert functions were moved into OSAL UtAssert library so it can be used in a wider variety of tests. This removes the CFE coverage-specific version, and changes all references to use the equivalent UtAssert macro.
jphickey
force-pushed
the
fix-1743-utassert-macros
branch
from
6837d44 to
961d4eb
Compare
jphickey
added
the
CCB:Ready
Contributor
Author
|
Marking as ready for review, although the CI test is reporting as failing now, it should work just fine once nasa/osal#1125 is in. |
skliper
approved these changes
Aug 3, 2021
zanzaben
previously requested changes
Aug 3, 2021
Contributor
zanzaben
left a comment
zanzaben
left a comment
There was a problem hiding this comment.
cFE_FTAssert_VOIDCALL from cfe_test.h can be replaced by the new UtAssert_VOIDCALL
astrogeco
removed
the
CCB:Ready
Contributor
|
CCB:2021-08-04 Wait until nasa/osal#1125 is in bundle-main |
Contributor
Opening new issue for this |
This was referenced Aug 9, 2021
astrogeco
added
the
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
A number of CFE coverage-specific macros and generic assert functions were moved into OSAL UtAssert library so it can be used in a wider variety of tests.
This removes the CFE coverage-specific version, and changes allreferences to use the equivalent UtAssert macro.
Fixes #1743
Testing performed
Build and run all tests
Expected behavior changes
None - UtAssert-provided macros should be equivalent in function
System(s) tested on
Ubuntu
Additional context
Requires nasa/osal#1125
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.